Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GENIE] Add support for genie-icetray. #41

Merged
merged 14 commits into from
Nov 5, 2024
Merged

[GENIE] Add support for genie-icetray. #41

merged 14 commits into from
Nov 5, 2024

Conversation

mjlarson
Copy link
Contributor

@mjlarson mjlarson commented Oct 2, 2024

Adds support for older genie-icetray simulation. Still needs tests added, but successfully reproduces the existing oneweight values in the files.

@mjlarson mjlarson marked this pull request as draft October 2, 2024 19:49
Copy link

github-actions bot commented Oct 2, 2024

Test Results

  5 files   -  1    5 suites   - 1   1m 55s ⏱️ -50s
101 tests + 7  101 ✅ + 7  0 💤 ±0  0 ❌ ±0 
505 runs   - 59  504 ✅  - 59  1 💤 ±0  0 ❌ ±0 

Results for commit cc68e3f. ± Comparison against base commit d4b29fa.

♻️ This comment has been updated with latest results.

@mjlarson
Copy link
Contributor Author

mjlarson commented Oct 4, 2024

Files needed for the tests are on cobalt-15:

  • /scratch/mlarson/simweights/src/examples/genie-icetray.140000A_000000.hdf
  • /scratch/mlarson/simweights/src/examples/genie-icetray.140000B_000000.hdf
  • /scratch/mlarson/simweights/src/examples/genie-icetray.140000C_000000.hdf
  • /scratch/mlarson/simweights/src/examples/genie-icetray.140000D_000000.hdf
  • /scratch/mlarson/simweights/src/examples/level2_genie-icetray.140000_000000.hdf

@mjlarson mjlarson marked this pull request as ready for review October 4, 2024 05:09
@kjmeagher
Copy link
Member

Thanks for doing this, can you please add the necessary input files to create the test files in contrib/book_simweights_testdata.py and then test with the output files?

@mjlarson
Copy link
Contributor Author

mjlarson commented Nov 2, 2024

Copied test i3 and hdf files over into /data/ana/Software/simweights/test-data/ and pointed the contrib/book_simweights_testdata.py genie-icetray files to there, but I'll let you decide whether you want to update the workflows to point to the tar file in that directory as well. I've updated the workflow in this branch to pull the testfile from /data/ana/Software

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d4b29fa) to head (cc68e3f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #41   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          756       799   +43     
=========================================
+ Hits           756       799   +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mjlarson mjlarson requested a review from kjmeagher November 3, 2024 03:42
@kjmeagher kjmeagher merged commit aadfc6f into main Nov 5, 2024
11 checks passed
@kjmeagher kjmeagher deleted the genie-icetray branch November 5, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants