-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GENIE] Add support for genie-icetray. #41
Conversation
c3163f5
to
781f34a
Compare
for more information, see https://pre-commit.ci
Files needed for the tests are on cobalt-15:
|
…bviously indexable. Remove some temporary local variables.
for more information, see https://pre-commit.ci
Thanks for doing this, can you please add the necessary input files to create the test files in contrib/book_simweights_testdata.py and then test with the output files? |
Copied test i3 and hdf files over into |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 756 799 +43
=========================================
+ Hits 756 799 +43 ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
Adds support for older genie-icetray simulation. Still needs tests added, but successfully reproduces the existing oneweight values in the files.